search

rbystrit / avro_gen

Avro record class and reader generator
Apache License 2.0
20 stars 18 forks source link

Various improvements #10

Closed hsheth2 closed 3 years ago

hsheth2 commented 3 years ago

Changes:

I ended up disabling some of the unittests related to logical types and protocols - I only disabled a subset of the ones that were failing to begin with, and fixed the others.

Closes #2 and resolves #6.

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1d7e14d). Click here to learn what that means. The diff coverage is 68.37%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage          ?   63.19%           
=========================================
  Files             ?       11           
  Lines             ?     1076           
  Branches          ?      211           
=========================================
  Hits              ?      680           
  Misses            ?      338           
  Partials          ?       58
Impacted Files Coverage Δ
avrogen/protocol.py 9.03% <0.00%> (ø)
avrogen/avrojson.py 75.36% <46.66%> (ø)
avrogen/dict_wrapper.py 65.62% <65.07%> (ø)
avrogen/core_writer.py 71.81% <68.70%> (ø)
avrogen/logical.py 66.66% <100.00%> (ø)
avrogen/schema.py 94.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d7e14d...5575e24. Read the comment docs.

hsheth2 commented 3 years ago

@rbystrit please let me know what you think

I'd be happy to do some work on the Python 3.6 support stuff if you think that'd be helpful

hsheth2 commented 3 years ago

@rbystrit I've added support for python3.6 and the Travis CI run has also succeeded: https://github.com/hsheth2/avro_gen/runs/1883671930.