Cleanup - Githubissues

rcackerman / parole-hearing-data

http://www.parolehearingdata.org/

21 stars 12 forks source link

Cleanup #25

Closed talos closed 9 years ago

talos commented 9 years ago

Removing some strange/dead code
Fixing bug where only 5 URLs were ever scraped (Issue #24)
Resolved one of the overly broad except statements (Issue #23)

rcackerman commented 9 years ago

Hey @talos - thanks so much for doing this! I'll merge and check that it runs tonight.

talos commented 9 years ago

@rcackerman No problem, thanks for taking a look! I'm working on a more serious refactor right now, to make it more intuitive to run the script ot update existing data (with total automation in mind).

I'd love it if you could provide some clarity on what data.csv's headers are, or if we should be using output2.csv for historical data. I was having problems parsing both of them as CSVs, unfortunately.

nikzei commented 9 years ago

Ok, I've been in trainings all day over here so apologies for being MIA.

THANKS so much for all of this work! Making serious progress - so exciting!!!

On Fri, Jan 9, 2015 at 9:34 PM, Rebecca Ackerman notifications@github.com wrote:

Merged #25 https://github.com/rcackerman/parole-hearing-data/pull/25.

— Reply to this email directly or view it on GitHub https://github.com/rcackerman/parole-hearing-data/pull/25#event-216915125 .