search

rcackerman / parole-hearing-data

http://www.parolehearingdata.org/
21 stars 12 forks source link

merging updated code #35

Closed nikzei closed 8 years ago

rcackerman commented 8 years ago

Apologies - I just saw this today. Looks like there's no notification setting in between "tell me about everything that happens with this repo" and "tell me nothing".

I left some comments - otherwise 👍 👍 .

rcackerman commented 8 years ago

@talos @nikzei I'm getting the error

Traceback (most recent call last):
  File "scrape.py", line 382, in <module>
    scrape(ARGS.input, ARGS.no_download)
  File "scrape.py", line 370, in scrape
    existing_parolees[key].update(parolee)
KeyError: (u'02A6328', '2016-04-26')

both after I tried merging and after I cloned your fork and tried from master.

rcackerman commented 8 years ago

@talos I fixed the above error (I think you had commented out line 59 for debugging), but I'm still getting errors when the scraper finds a new parolee that's not in the existing parolee list. Looking at scrape(), I'm not seeing where you're appending parolees that are completely new... am I missing something?

thejunglejane commented 8 years ago

8d17aef5c should resolve the new parolee errors.