search

rcaelers / workrave

Workrave is a program that assists in the recovery and prevention of Repetitive Strain Injury (RSI). The program frequently alerts you to take micro-pauses, rest breaks and restricts you to your daily limit.
https://www.workrave.org
GNU General Public License v3.0
1.61k stars 204 forks source link

Workrave is not compatible with GNOME Shell 46 #532

Closed jbicha closed 7 months ago

jbicha commented 8 months ago

Describe the bug I built workrave with --enable-gnome45 and tweaked metadata.json to include "46". When I tried enabling the extension on GNOME Shell 46 Beta, I got this error in Extension Manager

Extension workrave@workrave.org: TypeError: this._box.add_actor is not a function

Stack trace:
  _init@file:///usr/share/gnome-shell/extensions/workrave@workrave.org/extension.js:185:17
  ButtonBox@resource:///org/gnome/shell/ui/panelMenu.js:13:1
  PanelMenuButton@resource:///org/gnome/shell/ui/panelMenu.js:99:4
  WorkraveButton@file:///usr/share/gnome-shell/extensions/workrave@workrave.org/extension.js:162:3
  enable@file:///usr/share/gnome-shell/extensions/workrave@workrave.org/extension.js:518:27
  _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:264:38
  async*_onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:626:24
  _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:731:18
  createCheckedMethod/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:730:46
  enableExtension@resource:///org/gnome/shell/ui/extensionSystem.js:287:29
  EnableExtension@resource:///org/gnome/shell/ui/shellDBus.js:453:38
  _handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:329:38
  _wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34
  @resource:///org/gnome/shell/ui/init.js:21:20

Other Info Here is documentation about some of the changes in GNOME Shell 46

https://gjs.guide/extensions/upgrading/gnome-shell-46.html

rcaelers commented 8 months ago

Should be fixed in beta11. Not yet in 1.10

rcaelers commented 7 months ago

Also committed to 1.10 (5a6d52478d95f08b6bc8f6ded5984dac94cd31bc)

pieterdd commented 6 months ago

Thank you for implementing the fix. Any indication as to when it will be released? Ubuntu LTS and Fedora ship with GNOME 46 now, so the fix would be a big help to those users.

fmarier commented 6 months ago

Ubuntu LTS and Fedora ship with GNOME 46 now, so the fix would be a big help to those users.

The current Ubuntu LTS already has the required fixes: https://launchpad.net/ubuntu/+source/workrave/1.10.52-2ubuntu1

pieterdd commented 6 months ago

I see a Fedora release as well, and 1.10.52 - 4.fc40 is reported as installed on my machine, but the GNOME extension manager is still reporting the extension as incompatible :thinking:

image

jbicha commented 6 months ago

You need to report that issue to the Fedora maintainer.