search

rcallaby / Emacs-Guide

This is a open source guide to using Emacs
MIT License
5 stars 8 forks source link

Update advancedediting.md #60

Closed ghost closed 8 months ago

ghost commented 8 months ago

Pull Request

Feel free to delete parts of this pull request template that do not apply to your pull request, this is just used as a guideline

Description

[Provide a concise description of the changes introduced by this pull request.]

Related Issue(s)

[Link any related GitHub issues or pull requests here.]

Changes Made

[List the specific changes made in this pull request.]

Screenshots (if applicable)

[Add screenshots or gifs to showcase the changes, if relevant.]

Checklist

Additional Notes

[Include any additional information or context that may be relevant to this pull request.]

By submitting this pull request, I confirm that my contribution is made under the terms of the LICENSE for this project.

ghost commented 8 months ago

Hello, I made some changes by putting image names in the bracket. Can you see the changes? Thank you.

rcallaby commented 8 months ago

I have literally shown you how to do this task. Please just do it like the above code sample I provided.

Or in case you may not have seen that:

![ss2.png] (./images/ss2.png)

IT is not about the image name, carefully study the code. There should be an images folder with the images you tried to upload before.

ghost commented 8 months ago

Hello, I noticed the images were in private folder before, so I moved them to public folder. Please let me know if it works now. Thanks.

ghost commented 8 months ago

Thank you. I copied and pasted the line for 3 images. The Images folder says private. Hope it works. Thanks.

rcallaby commented 8 months ago

I don't have the images, you need to make the images folder public so that they can be included in the merge.

You're almost there. Just fix the images issue and I can merge this pull request.

ghost commented 8 months ago

Thanks. I found a way to make the Images folder public from the setting. Please try again and let me know.

rcallaby commented 8 months ago

Still no dice.

Are you adding the images folder in the commit? Because that is not included.

You need to do either: git add . Where there is a dot ( . ) after the add meaning add everything or something like this:

git add file1.txt folder/file2.txt file3.txt file4.txt file5.txt
ghost commented 8 months ago

I can do all with git add . command. Do I insert this line of code in the same place (advancedediting.md) where I put paths to the 3 images? Does it matter whether i put the git add . in the beginning or the end? Then I commit the changes again? Thanks.

rcallaby commented 8 months ago

Here is the way you do this as I am assuming you are using Git.

Are you using Git from the command line? Seriously hope so.

First you add all the files that need to be pushed by using git add .

Then you commit those files using the following command: git commit -m "Add meaningful commit message here"

Then you push that commit using: git push origin "yourbranchname"

Where obviously yourbranchname is the name of your branch

ghost commented 8 months ago

I think this will take me a while since I do not have git command prompt at the moment. Thanks.

rcallaby commented 8 months ago

How are you pushng code to my repository without git installed?

What code editor are you using?

ghost commented 8 months ago

Can I not participate and make changes on this project?

rcallaby commented 8 months ago

Weird. I have been exceedingly patient with you, trying to get you to understand things. All I did was ask two simple questions and you closed the pull request?

I have never blocked anyone on github before but I am seriously considering blocking you.