Remove the underscore prefix of `__bp_imported`

rcaloras / bash-preexec

⚡ preexec and precmd functions for Bash just like Zsh.

MIT License

862 stars 94 forks source link

Remove the underscore prefix of `__bp_imported` #123

Closed FranklinYu closed 2 years ago

FranklinYu commented 2 years ago

This formally exposes it as part of the public API. RFC: @dimo414.

Fixes #122.

FranklinYu commented 2 years ago

All of the suggestion above looks good to me, but apparently the test is currently broken. For example, the “include test” use __bp_preexec_and_precmd_install to decide whether bash-preexec is loaded, but this function isn’t there regardless. Shall I start another PR to fix the test before moving forward with this one?

FranklinYu commented 2 years ago

I’m glad that the CI is working, and it caught a bug. I’ll fix it before marking this as “ready for review”.

FranklinYu commented 2 years ago

I finally addressed all the comments. The history seems a bit messy; maybe consider merge by squashing the commits.