search

rcaloras / bash-preexec

⚡ preexec and precmd functions for Bash just like Zsh.
MIT License
862 stars 94 forks source link

Configure the first workflow for GitHub Actions #125

Closed FranklinYu closed 2 years ago

FranklinYu commented 2 years ago

After this is verified to work, we can probably remove the Travis CI configuration.

dimo414 commented 2 years ago

This looks great to me (so +1 for merging as-is), but it would be nice to have coverage of multiple Bash versions. Here's the approach I took for bash-cache (with a custom Docker image). There's also an official bats/bats image which appears to support different versions, though it seems odd to me that they build the image for every run.

FranklinYu commented 2 years ago

Yes, that sounds like a viable follow-up. Meanwhile I plan to add macOS Big Sur as another platform, since it’s using a very old Bash.

dimo414 commented 2 years ago

It's probably sufficient to just test against Bash 3.2, which is what macOS is stuck on.

rcaloras commented 2 years ago

Merged, fixed permissions for install (https://github.com/rcaloras/bash-preexec/commit/b1630c76020416ccaaf56ecfd3f1f066dbd2461e), updated Readme (https://github.com/rcaloras/bash-preexec/commit/3e563be4f143366dc21d795d311da506be6fb75c)