ShellCheck highlights several issues with the file - Shellcheck could be disabled, or issues resolved

rcaloras / bash-preexec

⚡ preexec and precmd functions for Bash just like Zsh.

MIT License

862 stars 94 forks source link

ShellCheck highlights several issues with the file - Shellcheck could be disabled, or issues resolved #132

Closed jamie-wearsafe closed 2 years ago

jamie-wearsafe commented 2 years ago

It can be disabled by adding this line to the shell file:

# shellcheck disable=SC2292,SC2250,SC2086,SC1087,SC2248,SC2001,SC1007,SC2034

Issues can be seen by adding the script to the shellcheck online editor:

dimo414 commented 2 years ago

Feel free to send a PR addressing the ShellCheck findings, but it would be good to limit the disable directives to specific offending lines where possible.

rcaloras commented 2 years ago

Should be addressed in #135