FIx: Remove superfluous arg to __bp_set_ret_value

rcaloras / bash-preexec

⚡ preexec and precmd functions for Bash just like Zsh.

MIT License

862 stars 94 forks source link

FIx: Remove superfluous arg to __bp_set_ret_value #139

Open glensc opened 1 year ago

glensc commented 1 year ago

__bp_set_ret_value() takes just one argument:

https://github.com/rcaloras/bash-preexec/blob/a44754f5c3ca76b0330324680670cb8574d2768f/bash-preexec.sh#L180-L182

glensc commented 1 year ago

Seems it's trickery to set $_:

https://github.com/rcaloras/bash-preexec/commit/d056f7dc37e30724f09eb7487a060311caf49990

perhaps it then needs better code documentation, i.e for __bp_set_ret_value() function.

rcaloras commented 1 year ago

@glensc, thanks for submitting the PR.

Seems it's trickery to set $: Yes, it effectively propagates the $ variable so it can continue to be used. Feel free to close the PR or edit the the comments if you like.