search

rcaloras / bashhub-client

:cloud: Bash history in the cloud. Indexed and searchable.
https://bashhub.com
Apache License 2.0
1.25k stars 80 forks source link

Fish support? #14

Open igorescobar opened 8 years ago

igorescobar commented 8 years ago

Doest it support fish?

rcaloras commented 8 years ago

Hi @igorescobar, thanks for your interest in Bashhub :D

Not yet, but should be pretty easy to add. Does fish have any precmd or preexec hooks like zsh? I built bash-preexec to add this to Bash.

Would be awesome if you put in a PR to add it. You'd basically have to create bashhub.fish in https://github.com/rcaloras/bashhub-client/tree/master/bashhub/shell. You could easily template it from bashhub.zsh Then add a new check during install to check if the shell is Fish.

rcaloras commented 8 years ago

Looks like there's a few events that could be potentially tapped into https://github.com/fish-shell/fish-shell/pull/1563

gardinermichael commented 5 years ago

Any word?

anaibol commented 4 years ago

+1

rcaloras commented 4 years ago

hey @paysonwallach, any interest in submitting a PR for this to help out the main project? Saw you had an implementation on your fork: https://github.com/paysonwallach/bashhub-client :)

paysonwallach commented 4 years ago

Sure! Great to see version 2, by the way.

weeebdev commented 3 years ago

Hi! Got an error while installing.

setup (line 13): Unsupported use of '='. In fish, please use 'set bash_profile_hook '
### Bashhub.com Installation.
### This Should be at the EOF. https://bashhub.com/docs
if [ -f ~/.bashhub/bashhub.sh ]; then
    source ~/.bashhub/bashhub.sh
fi
''.
warning: Error while reading file setup

Do you mind fixing, @paysonwallach ?