search

rcaneill / xnemogcm

Interface to open NEMO global circulation model output dataset with xarray and create a xgcm grid.
https://xnemogcm.readthedocs.io/
MIT License
21 stars 9 forks source link

metrics.compute_missing_metrics kwarg 'periodic' not used #82

Closed callumrollo closed 6 months ago

callumrollo commented 6 months ago

Describe the bug

Function metrics.compute_missing_metrics has a kwarg periodic=False which is not used. Within this function a call is made to xgcm.Grid

grid = xgcm.Grid(ds, periodic=False)

Perhaps this should be

grid = xgcm.Grid(ds, periodic=periodic)

Using the kwarg from the metrics.compute_missing_metrics . Otherwise the kwarg periodic should be removed from metrics.compute_missing_metrics