Closed callumrollo closed 6 months ago
Describe the bug
Function metrics.compute_missing_metrics has a kwarg periodic=False which is not used. Within this function a call is made to xgcm.Grid
metrics.compute_missing_metrics
periodic=False
grid = xgcm.Grid(ds, periodic=False)
Perhaps this should be
grid = xgcm.Grid(ds, periodic=periodic)
Using the kwarg from the metrics.compute_missing_metrics . Otherwise the kwarg periodic should be removed from metrics.compute_missing_metrics
periodic
Describe the bug
Function
metrics.compute_missing_metrics
has a kwargperiodic=False
which is not used. Within this function a call is made to xgcm.Gridgrid = xgcm.Grid(ds, periodic=False)
Perhaps this should be
grid = xgcm.Grid(ds, periodic=periodic)
Using the kwarg from the
metrics.compute_missing_metrics
. Otherwise the kwargperiodic
should be removed frommetrics.compute_missing_metrics