search

rcarragh / c212

Methods for detecting safety signals in clinical trials using groupings of adverse events by body-system or system organ class.
GNU General Public License v3.0
0 stars 2 forks source link

Dependency versioning #2

Closed rrrlw closed 3 years ago

rrrlw commented 4 years ago

Adding version requirements to dependency lists in DESCRIPTION can help improve package robustness (in case older dependency versions break code). Would you be willing to add a version requirement for the coda dependency? (e.g. coda >= 0.19 or whichever min version you choose)

Part of this JOSS review.

rcarragh commented 4 years ago

I've updated the DESCRIPTION to code (>= 0.19) as you suggest. Older version should be OK but I agree that this is better.

rrrlw commented 3 years ago

Looks great, thank you!