search

rcastberg / sure_petcare

Python library for accessing sure connect petflap
GNU General Public License v3.0
55 stars 15 forks source link

Reformat code with black #13

Open therefromhere opened 5 years ago

therefromhere commented 5 years ago

using black .

https://github.com/python/black

strix-technica commented 5 years ago

This is @rcastberg's project so it's his call but I can't say I'm keen on this. It will cost time without any obvious functional benefit. At the same time, it will break anybody who's customised code without having their customisations pulled back into mainline.

I realise that my/René's coding style might not be to everyone's taste but unless you're willing to put in the lion's share of dev work, it's probably better to leave it in a format that is comfortable for those doing the majority of the work.

therefromhere commented 5 years ago

Yeah that's fine, I thought I'd put it up and see if you guys were ok with it since black is becoming a very popular formatter for python. I won't be offended if you reject the PR though.