rcasteran / jarvis4se

JARVIS for Systems Engineers
https://regis-casteran.gitbook.io/jarvis4se/
MIT License
3 stars 1 forks source link

Attribute not created when added in an already existing model #29

Closed rcasteran closed 2 years ago

rcasteran commented 2 years ago

Impacted version jarvis4se version: 1.1.3

Describe the bug Taking an already existing model without an attribute. When creating an new attribute, Jarvis indicates that it is created without any errors. But the xml is not containing it. When trying to assign it a value, Jarvis does nothing without showing an error.

To Reproduce Assuming that test is a model containing a single function F1 Execute the followings commands:

%%jarvis
with test
a is an attribute

Jarvis indicates: test.xml parsed a is an attribute (added) test.xml updated

%%jarvis
with test
The a of F1 is "toto"

Jarvis indicates: test.xml parsed

Expected behavior Jarvis must create the attribute in the xml file

Desktop (please complete the following information):

Not2behere commented 2 years ago

A workaround for this :

  1. Delete existing .xml file
  2. Rerun your notebook(restart kernel + run all cells) with the new Jarvis version

This is due to the fact that at the root of the xml : <attributeList/> has been added in 1.1.3. and wasn't there before. So in your .xml made from previous version jarvis cannot find this tag.