search

rcbops / ansible-lxc-rpc

Ansible Playbooks to deploy openstack
https://rcbops.github.io/ansible-lxc-rpc/
Apache License 2.0
38 stars 31 forks source link

stable/icehouse version of cloudserver-aio.sh pulls master branch by default #493

Closed nrb closed 9 years ago

nrb commented 10 years ago

This behavior likely does not affect customers, but can affect those of us who try to build AIOs based on different versions.

Since the names and layouts of playbooks differ between master and stable/icehouse, I think the cloudserver-aio.sh script should default to stable/icehouse on that branch, rather than master.

sigmavirus24 commented 10 years ago

Should probably port this to proposed/juno too

nrb commented 10 years ago

Good point; IMO, the cloudserver-aio.sh script in each branch should point to that branch.

sigmavirus24 commented 10 years ago

I bet we could write something to parse the branch from the git information

nrb commented 10 years ago

Well, the issue's not solely the branch name. The names of the other files, especially playbooks, will also have to be valid for that branch.

nrb commented 10 years ago

Also, if you run this via the heat template, the script is downloaded separately from the repo, as seen here: https://github.com/rcbops/ansible-lxc-rpc/blob/stable/icehouse/scripts/rpc9.0.0-aio-rax-heat-template.yml#L77

nrb commented 10 years ago

One thought would be to edit the heat template to use the repo_branch string when building the install_script_url variable.

sigmavirus24 commented 10 years ago

True, we also need to make sure rpc_user_config.yml is correct for each.

cloudnull commented 9 years ago

Presently this issue has been resolved as the branch bits have been corrected in master. @sigmavirus24 @nrb we may want to review how the rpc_user_config.yml is being built in our various releases and if it needs updating we should open another issue.