search

rcbops / gh2

A tool to transmogrify GitHub issues to any desired output
Other
3 stars 4 forks source link

Add persistent caching of API responses #6

Closed git-harry closed 7 years ago

git-harry commented 7 years ago

Add file-based caching to gh2. This reduces the number of API requests, that count toward the API rate limit, that need to be made by using cachecontrol to store the data from previous requests and manage changes using ETags.

Recent additions to gh2, such as label support, has increased the number of API requests that are being made causing rate limits to be hit more frequently. Without a mechanism to reduce the number of API requests that are counted by the rate limit, gh2 can be difficult to use without impacting general use of GitHub.

Connected https://github.com/rcbops/u-suk-dev/issues/489

git-harry commented 7 years ago

Ready for review once the connected issue is approved.

jpmontez commented 7 years ago

I've used this and it works perfectly. I'd say it's ready for a merge.

b3rn4rd0s commented 7 years ago

@sigmavirus24 If you have time to help out with this, it would be most helpful.

sigmavirus24 commented 7 years ago

Yep. This looks perfect. Will probably need a touch-up once I get around to making cachecontrol appropriate for cratonclient. 🎉

b3rn4rd0s commented 7 years ago

@jpmontez @sigmavirus24 @git-harry Thanks people!