rcbops / opencenter

http://www.rackspace.com/cloud/private/openstack_software/
Other
9 stars 12 forks source link

[DE37] Poor error reporting on failed key install for apt repo #458

Closed jcannava closed 11 years ago

jcannava commented 11 years ago

the script is not checking to see if the key is installed and the process then fails when attempting to 'apt-get update'. A simple check on the return status and an error message would prevent needless debugging.

andymcc commented 11 years ago

Although apt-get update should never have been run (since set -e is enabled the failure of apt-key command will kill the script) - I've added a line to make that clear and explicitly exit 1. https://github.com/rcbops/opencenter-install-scripts/pull/164