update_hp_firmware.py does not flash mainboard firmware

[rax-rstark]

Tried running for TD last week, mainboard was on 2.77, would not upgrade to 2.80 until I changed the following lines:

https://github.com/rcbops/openstack-ops/blob/8c68c9fc41628d3df26543429b3c37e4e2cf170f/playbooks/files/update_hp_firmware.py#L149-L151

iLo update to 2.77 worked fine, as expected.

First pass run:

root@698703-infra01:/opt# git clone -b ansible-eol https://github.com/rcbops/openstack-ops.git /opt/openstack-ops
Cloning into '/opt/openstack-ops'...
remote: Enumerating objects: 1945, done.
remote: Counting objects: 100% (57/57), done.
remote: Compressing objects: 100% (41/41), done.
remote: Total 1945 (delta 31), reused 28 (delta 15), pack-reused 1888
Receiving objects: 100% (1945/1945), 475.90 KiB | 0 bytes/s, done.
Resolving deltas: 100% (1229/1229), done.
Checking connectivity... done.

root@698703-infra01:~# python /opt/openstack-ops/playbooks/files/update_hp_firmware.py -i
Verified supported hardware: ProLiant DL380 Gen9
Checking for intial pre-requisites...

*********************************************
     INSTALLING REQUIRED UTILITIES ONLY.
*********************************************

Verifying current NIC version: Needs update ( -> 5719-v1.46NCSIv1.5.1.0)

Verifying current SYSTEM-MELTDOWN version: Already current (v2.76(10/21/2019)P89). Nothing to do.

Verifying current RAID version: Already current (7.00-0). Nothing to do.

Verifying current ILO version: Needs update (2.74 -> 2.77)

Verifying current Intel 10G NIC Versions:
 em50 needs update (800005B6 -> 80000636)
 em49 needs update (800005B6 -> 80000636)
 p4p2 already current. Nothing to do.
 p4p1 already current. Nothing to do.
 p1p1 already current. Nothing to do.
 p1p2 already current. Nothing to do.

SUMMARY: Needs Update

After modification:

root@698703-infra01:~# python /opt/openstack-ops/playbooks/files/update_hp_firmware.py -i
Verified supported hardware: ProLiant DL380 Gen9
Checking for intial pre-requisites...

*********************************************
     INSTALLING REQUIRED UTILITIES ONLY.
*********************************************

Verifying current NIC version: Needs update ( -> 5719-v1.46NCSIv1.5.1.0)

Verifying current SYSTEM-MELTDOWN version: Needs update (v2.76(10/21/2019)P89 -> 10/16/2020)

Verifying current RAID version: Already current (7.00-0). Nothing to do.

Verifying current ILO version: Needs update (2.74 -> 2.77)

Verifying current Intel 10G NIC Versions:
 em50 needs update (800005B6 -> 80000636)
 em49 needs update (800005B6 -> 80000636)
 p4p2 already current. Nothing to do.
 p4p1 already current. Nothing to do.
 p1p1 already current. Nothing to do.
 p1p2 already current. Nothing to do.

SUMMARY: Needs Update