rcbops / rpc-upgrades

Leapfrog/Incremental Upgrades for RPC OpenStack
1 stars 17 forks source link

Fix misspelling and incorrect syntax #374

Closed nipsy closed 4 years ago

nipsy commented 5 years ago

This pull request fixes the basic problems with this check. However, the bigger issue is, for a lot or even almost all of our environments, the status for indices is probably always going to be yellow since we're running stand alone ES nodes. @sdhardy ran into this during the Pipedrive upgrade. It was easy enough to fix with something like:

for i in $(curl -s localhost:9200/_cat/indices?v | awk '{print $3}'); do curl -s -XPUT localhost:9200/${i}/_settings -d '{"index":{"number_of_replicas":0}}'; done

But I'm not sure we're doing anything like this elsewhere before this check, so I imagine this check will fail in a lot of our environments.

Either way, these changes here should still be made.

rpc-jenkins-svc commented 5 years ago

Thank you for submitting a pull request to this project!

Once all check jobs have passed and the pull request has received a sufficient number of reviews, the repository's gate jobs can be triggered by adding a comment of :shipit: to this pull request.

When the gate jobs have completed successfully, this pull request will get merged automatically.