search

rcbyr / keen-slider

The HTML touch slider carousel with the most native feeling you will get.
https://keen-slider.io/
MIT License
4.67k stars 214 forks source link

bug fix last slide not visible when loop true #357

Open aravindemmadishetty opened 1 year ago

aravindemmadishetty commented 1 year ago

352

truongleit commented 1 year ago

@rcbyr could you please consider merging this PR?

rcbyr commented 1 year ago

Thanks for your PR. But it doesn't work. Even if the last slide is displayed correctly, the first slide will then disappear. The problem has only been relocated. Since the slider does not duplicate slides, it probably does not make sense to activate the loop if there are too few slides. In this case there is enough space in the viewport to display all slides anyway.

aravindemmadishetty commented 12 months ago

What you said is true, but I want the loop because the slides in the slider are dynamic. so I want this functionality. Can you please see if you can add this scenario ?