search

rcdexta / react-event-timeline

A responsive event timeline in React.js
https://rcdexta.com/react-event-timeline
MIT License
536 stars 56 forks source link

React 16 Support #15

Closed aogaili closed 7 years ago

aogaili commented 7 years ago

An older version of React is being loaded as a dependency:

https://github.com/rcdexta/react-event-timeline/blob/31c91670c26322e03ba42b9b4cc267e3222be8c3/package.json#L79-L82

I think it should be loaded as per dependency.

rcdexta commented 7 years ago

Will fix it this weekend. Thanks for pointing out.

aogaili commented 7 years ago

Thank you!

rcdexta commented 7 years ago

Upgraded to React 16 now. If your parent application uses React 15.x, this should work too.. Please pull v1.3.5

rcdexta commented 7 years ago

react and react-dom are peer dependencies now.. @aliogaili: Let me know if this works for you..

aogaili commented 7 years ago

Thanks @rcdexta it's working great now.

Just quick question, I noticed that the package.json doesn't have a version attribute. I'm assuming you're using tags to publish. Is there a reason behind this choice? because it's the first time I see this and do you've some resources where I learn more about it.

Thanks again for closing this issue.

rcdexta commented 7 years ago

I use semantic versioning workflow to take care of version bumping based on whether it is a feature/fix being committed and you can look here for more info: https://github.com/semantic-release/semantic-release

aogaili commented 7 years ago

Much appreciated, thanks @rcdexta

aogaili commented 7 years ago

Wow this semantic versioning is amazing, the node ecosystem keep on surprising me everyday, lots of smart folks around :)