Fix the vbTab / vbBack mess

rcdmk / aspJSON

A fast classic ASP JSON parser and encoder for easy JSON manipulation to work with the new JavaScript MV* libraries and frameworks.

MIT License

203 stars 89 forks source link

Closed skacurt closed 6 years ago

skacurt commented 6 years ago

What is done with last two commits before the bump is totally wrong and harmful.

This PR claims to fix the following problems.

There's no built-in vbback constant in VBScript, it must be defined with a value Chr(8) explicitly.
The parser and serializer must keep handle both backspace (introduced with vbBack) and tab (built-in vbTab) characters and their escape sequences \b and \t.

rcdmk commented 6 years ago

Hi! You are right! I must have done that while almost asleep (I have a 18 days old baby).

The only considerations about this PR is that I prefer to integrate it to develop branch first and some other comments I'll add to the code.

Thank you for your contribution. It is very welcome. Please, take some time to read my considerations.

skacurt commented 6 years ago

Hi Ricardo, as long as the issue understood it's OK to close this PR. You know what you need to do. Thanks.

skacurt commented 6 years ago

Let's continue from #57