Simplify AND, OR - Githubissues

rce-incorporated / Fiu

Luau bytecode interpreter for Luau

MIT License

90 stars 16 forks source link

Simplify AND, OR #28

Closed Someon1e closed 7 months ago

Someon1e commented 7 months ago

~~- Adds --!strict typechecking, any is used where something can't be typed.~~ ~~- Changes string pattern PC: %s to PC: %d~~

Simplified AND, OR implementations

green-real commented 7 months ago

As per @TheGreatSageEqualToHeaven decision, we do not want to add type annotations to Fiu. Could you also avoid formatting it? We liked the way it was formatted before so we want to keep that the same.

I'll merge it when you make these changes I mentioned, specifically for the simplified AND, OR implementations which do look good to me.

green-real commented 7 months ago

yeah LGTM!