search

rcedgar / muscle

Multiple sequence and structure alignment with top benchmark scores scalable to thousands of sequences. Generates replicate alignments, enabling assessment of downstream analyses such as trees and predicted structures.
https://drive5.com/muscle
GNU General Public License v3.0
188 stars 22 forks source link

source files are missing #2

Closed joelb123 closed 3 years ago

joelb123 commented 3 years ago

ScoreType.h and FileBuffer.h are referenced in the code but not included with the release. They seem to come from amap, which is not listed as a dependency.

This is the first barrier that anybody wishing to build the code will run into.

rcedgar commented 3 years ago

This is not correct. The files scoretype.h and filebuffer.h (all lower case) are included in the repo and make completes successfully after fixing the ver_counter.h bug (which was correct).

joelb123 commented 3 years ago

No, if you look at probcons.h it contains #include "ScoreType.h". FileBuffer.h ref is contained in sequence.h. I checked against the repo just now.

rcedgar commented 3 years ago

Yes you were right, sorry about that. Bad grepping, plus I'm running Ubuntu under WSL which apparently considers ScoreType.h and scoretype.h to be the same file, as does Visual Studio -- lesson learned. Thanks for the catch. Fixed now, hopefully :-}