search

rcereno / REDX

0 stars 0 forks source link

Code Review Comments (Bryce Raymundo) #14

Open yarecryb opened 4 months ago

yarecryb commented 4 months ago
  1. Update in-code documentation, could use more comments to describe what each endpoint does.
  2. In search_catalog, the parameters could be moved to a class to make the function's arguments easier to read and edit.
  3. Lots of commented-out code in carts.py. Is there a reason you are not keeping the class for CartItem commented out but not using it for function parameters?
  4. Can combine lots of SQL statements into one. The select statement to get game prices could be updated in set_item_quantity.
  5. Lots of redundant and commented-out code in the checkout function should be deleted. A lot of the SQL statements in that function can also be condensed.
  6. You started implementing ledgerizing but in the checkout but finishing it would help make edits to the database easier.