search

rchain-community / rgov

RChain liquid democracy demo: capability sharing, mailbox, directory, chat, ...
https://rchain-community.github.io/rgov/
10 stars 14 forks source link

indentation style / tools? #12

Open dckc opened 4 years ago

dckc commented 4 years ago

I don't think I have seen this indentation style before. Do you have tools that help maintain it?

I'm in the habit of using scala tools to maintain rholang. (esp. emacs indent-region in scala mode).

https://github.com/rchain-community/rho-bot/blob/f532b2e636c6c6dc6d940fa0e8e0d51d5e603c77/Community.rho#L66-L82

dckc commented 4 years ago

@jimscarver says he's not wedded to this extra indentation for contracts; not sure where it came from.

dckc commented 3 years ago

CONTRIBUTING.md should say that yarn lint-check and yarn lint:types should pass for all contributions.

We should set up github actions to check that for us.

jimscarver commented 3 years ago

neither lint-check or yarn lint:types pass in master. The only new errors I see are insignificant. The only one in our code concerns import of a json file which I commented in the code.

Bill-Kunj commented 3 years ago

Are we still working this issue?

dckc commented 3 years ago

I would like to see tool support for rholang formatting, so please keep this open.

Bill-Kunj commented 3 years ago

Agreed. From an old mentor: "Write the code, we can always pretty-print it." So, we need a pretty-print tool.