rchain-community / rgov

RChain liquid democracy demo: capability sharing, mailbox, directory, chat, ...
https://rchain-community.github.io/rgov/
10 stars 14 forks source link

deploys lack feedback on execution errors, finalization, explorer #235

Open dckc opened 3 years ago

dckc commented 3 years ago

for example, a link to the block in the https://revdefine.io explorer... or info about whether the block is finalized or whether executing the code resulted in an error

This is a TODO from 9c537aa55a87

cc @Bill-Kunj

Bill-Kunj commented 3 years ago

This is a TODO from 9c537aa

cc @Bill-Kunj

@dckc Yep, this would be good diagnostic info. Please flesh this out a bit more, though. The link you provide to the commit doesn't really explain anything.

Bill-Kunj commented 3 years ago

for example, a link to the block in the https://revdefine.io explorer...

@dckc I really like https://revdefine.io/. Provides excellent macro-view diagnostics.

or info about whether the block is finalized

It seems we would have to implement another call to the rnode in participate.js? I'm not sure how to go about that. My knowledge of the API isn't as good as yours.

or whether executing the code resulted in an error

Kinda thought this is apparent from the results section we display, but maybe it's not. Unless you're talking about the ambiguous error deploying rholang code, which we can't do anything about and, I thought, you were working to resolve with the core team.

This is a TODO from 9c537aa

cc @Bill-Kunj

I think each of these points is large enough to be worthy of an individual issue.

Bill-Kunj commented 3 years ago

No forward-looking effort on this, closing.

dckc commented 3 years ago

feel free to reflect a low priority in any way you like, but I think the app is deficient without this. Perhaps I should change it to a bug...

Bill-Kunj commented 3 years ago

feel free to reflect a low priority in any way you like, but I think the app is deficient without this. Perhaps I should change it to a bug...

Agreed.

David405 commented 3 years ago

@dckc @Bill-Kunj how do you want the block info and what details do you want to be displayed? I can add that to the result data.

dckc commented 3 years ago

I can't think of a way to be more clear than what's in the description. Which part is not sufficiently clear?