connect button should throw error if metamask extension is not found

rchain-community / rgov

RChain liquid democracy demo: capability sharing, mailbox, directory, chat, ...

https://rchain-community.github.io/rgov/

10 stars 14 forks source link

Open ifebrand6 opened 3 years ago

ifebrand6 commented 3 years ago

I started the application
navigated to the voting interface
clicked on connect wallet
I didn't get any response as I don't have metamask extension installed
In such a scenario, I believe an error shown be shown to the user that "metamask extension not found" or the user should be redirected to download metamask extension.

151

David405 commented 3 years ago

@ifebrand6 as it is now, the error is shown in the console but I will add an alert message or something to notify the user

Bill-Kunj commented 3 years ago

@ifebrand6 as it is now, the error is shown in the console but I will add an alert message or something to notify the user

@David405 This is a good idea. @jimscarver Is this a requirement for the rv2021 interface?

David405 commented 3 years ago

@Bill-Kunj I am rewriting the way signin works, so this wouldn't be an issue