search

rchain / rchain-api

Obsoleted in favor of https://github.com/rchain-community/rchain-api. Use at your own risk.
Other
8 stars 4 forks source link

Update api for required cost accounting parameters #14

Closed JoshOrndorff closed 6 years ago

JoshOrndorff commented 6 years ago

As on node 0.7, phlo-price, and phol-limit are required. The API should reflect that and require them as well.

goral09 commented 6 years ago

https://github.com/rchain/rchain/pull/1555/files#diff-716fefb13120384ecb72c40ff4a9bca0R310

dckc commented 6 years ago

@crypto-coder writes:

How to version the API against a moving RNode target?

I'd say: with issues such as this one and #6

And yes, any change in the gRPC layer is an observable change in the API for this package, so the version number should change. Breaking changes in the gRPC layer imply breaking changes in this package.

JoshOrndorff commented 6 years ago

Do we agree that our [https://semver.org/](semantic versioning) numbers will just match core?

JoshOrndorff commented 6 years ago

Our intention is to stay up to date with the node releases, and making a semi-formal agreement not to lag behind them by more than one week.