rchain / rchain-api

Obsoleted in favor of https://github.com/rchain-community/rchain-api. Use at your own risk.

Other

8 stars 4 forks source link

Update protobuf to 0.7.1 / repackage for NPM #26

Closed crypto-coder closed 5 years ago

crypto-coder commented 5 years ago

Updating the protobuf specs to use the new ones from RChain 0.7.1 Commit hash [27d722e] https://github.com/rchain/rchain/tree/dev/models/src/main/protobuf

Also, repackaging RNode.js for the first NPM release

Should resolve the following issues:

5 - Repackage for NPM

6 - update protos; remove Channel and Quote

14 - Update api for required cost accounting parameters

dckc commented 5 years ago

Darn; it's not tracking comments like I thought it would. Oh well.

dckc commented 5 years ago

@JoshOrndorff darn... we lost the travis config when we moved from your account.

crypto-coder commented 5 years ago

Let's not use the same name as rholang for different functionality. sha256HashData or something?

And let's export the rholang-compatible functions too.

Added Rholang-compatible functions and renamed these convenience variants with a 'simplified' prefix. Also moved these functions out of the RNode interface so they are top-level now. New function names are:

sha256Hash - Rholang-style, bytes-in, bytes-out
keccak256Hash - Rholang-style, bytes-in, bytes-out
blake2b256Hash - Rholang-style, bytes-in, bytes-out
simplifiedSHA256Hash - Convenience, any RHOCore-compatible data in, HEX string out
simplifiedKeccak256Hash - Convenience, any RHOCore-compatible data in, HEX string out
simplifiedBlake2b256Hash - Convenience, any RHOCore-compatible data in, HEX string out

Updated unit tests with your work on your fork, and added the normal vs simplified tests.

JoshOrndorff commented 5 years ago

I can't figure out how to enable travis here.Admittedly, I struggle the first time as well. But I do see how to enable it on my other repos and rchain-community repos. So I'm pretty sure this is a permissions issue. I'm contributor here, but not admin.

dckc commented 5 years ago

Please do git merge my changes in #28 thru a10c826 . Especially critical is:

RHOCore: chan.quote is no more 3a347d6

along with test data 2e92460 and test harness 464009f

Without this fix, (a) signatures aren't compatible, and (b) rnode throws exceptions when we send it mal-formed Pars

crypto-coder commented 5 years ago

Please do git merge my changes in #28 thru a10c826 . Especially critical is:
* **RHOCore: chan.quote is no more** [3a347d6](https://github.com/rchain/rchain-api/commit/3a347d60f82786470770dc842d64e6623c192868)
along with test data 2e92460 and test harness 464009f

Without this fix, (a) signatures aren't compatible, and (b) rnode throws exceptions when we send it mal-formed Pars

Merged in all changes from your branch "live-tests", and ran all checks / tests. This should include all necessary differences at this point