rchain / rchip-proposals

Where RChain improvement proposals can be submitted
Apache License 2.0
8 stars 5 forks source link

Implementing A Breaking Change Release #10

Open SteveHenley opened 4 years ago

SteveHenley commented 4 years ago

Summary:

SysOps runbook procedure for a breaking change release.

Definition:

Breaking change release is a release that is not backwards compatible. Should these procedures apply at the root shard level only or all shards? Protocol (data structures and/or API call parameters) breaking changes vs. specific implementation breaking change (scala vs java vs rust) ? Note that multiple language nodes can run in the same shard .. it might improve security and resilience.

Validators:

All bonded node validators must participate in a breaking change release implementation to migrate from the old network to the new network at the block height announced by the Tech Governance team (with inputs from dev team).

  1. Editorial, approval & communication
    1. Editorial - review and edit submitted release request.
    2. Approval - review edited release request
    3. Communication
      1. Announcement procedure
        1. Atlassian release notes
        2. Social media
          1. developer.rchain.coop website
          2. Discord - development channel on RChain pub
          3. Telegram - RChain community
          4. Weekly community debrief
          5. RChain YouTube channel
    4. List breaking change release in registry.
      1. Release number
      2. Change classification
        1. Soft update
        2. Breaking change
        3. Hard fork
      3. Implementation date
  2. Validator identification - identify which validators are involved in the breaking change release implementation.
  3. (Third item - help me here Tomislav, see log: tech governance is needed)
    1. https://docs.google.com/document/d/1fvxMC6Bt5XwbVaLzYPy6ZPB8KzJvASO2sKRC6ZCPwpI/edit
  4. Metrics
    1. Block height start - the block number at which validators must begin to implement a breaking change release.
      1. The recommendation is to treat validators that have not upgraded, as dead nodes until they upgrade
      2. How do we ensure that this doesn’t lead to a network security issue because most validators have not upgraded to the new release at the specified block height?
    2. Block grace period - the number of blocks within which validators must implement a breaking change release before being penalized (slashed?)
    3. Block height slash - the block number at which validators will be penalized for not completing a breaking change release implementation.
      1. (Incomplete implementation penalty - Slashing?)
  5. Issue tree or stream??
  6. New feature not being supported by existing validators will cause them to be slashed
    1. Have some block number where everyone has to update by a specific time
      1. Validators do not upgrade their block will be orphaned
      2. As a result validator will fork itself
    2. Possible resolution - is to have version number field in block. When a node receives a higher version block, it can simply pass on the block to other validators without doing anything with it.
      1. Incorporate into the version numbering scheme, semantics about whether the new version features break or cause slashing etc or not..
      2. Breaking/slashing causing changes should mostly be combined together into a single release, so validators have time to react and upgrade
      3. Have minimum feature set that should be support by validators for example Rholang 1.0.1
        1. Without upgrade say all features in Rholang will be breaking
        2. Example: 0.9.25.x / supports Rholang 1.0.1
    3. Casper -
9rb commented 4 years ago
  1. Classify what's a breaking change vs not
  2. Provide guidelines to implement a breaking change

This is similar to meta-eip

zsluedem commented 3 years ago

@SteveHenley Does this issue talk about the first breaking changes Rchain is going to make or just the guidelines for breaking changes?

SteveHenley commented 3 years ago

@zsluedem I believe this issue was created to address the guidelines for break changes. I will confirm this. I have added your question to the tech governance agenda for this Thursday.

SteveHenley commented 3 years ago

We need to discuss communication with exchanges. If there are any bugs we should have instantaneous stopping of transactions. We should be prepared for halting and rollbacks to dissuade hackers.