search

rchatley / extreme_startup

Other
265 stars 92 forks source link

One New Question and bundle update #30

Open tclavier opened 11 years ago

rchatley commented 11 years ago

Hi, thanks for the pull request. I have a few comments, as it seems to mix a few things into one PR:

1) why do you need the new EventMachine version? 2) can you add a spec for the previous day question? 3) I'm not sure about the general knowledge question, perhaps you could just keep this for your own fork rather than pushing it into master.

On Thu, Jun 13, 2013 at 10:10 AM, Thomas Clavier notifications@github.comwrote:

You can merge this Pull Request by running

git pull https://github.com/tclavier/extreme_startup master

Or view, comment on, or merge it at:

https://github.com/rchatley/extreme_startup/pull/30 Commit Summary

  • New Question : what is the previous day of ...
  • migrate to last eventmachine

File Changes

  • M Gemfilehttps://github.com/rchatley/extreme_startup/pull/30/files#diff-0(2)
  • M Gemfile.lockhttps://github.com/rchatley/extreme_startup/pull/30/files#diff-1(97)
  • M lib/extreme_startup/question_factory.rbhttps://github.com/rchatley/extreme_startup/pull/30/files#diff-2(25)

Patch Links: