search

rchatley / extreme_startup

Other
265 stars 92 forks source link

allow to run extreme startup without side effect on it's own machine by docker #36

Closed wadouk closed 9 years ago

mostalive commented 9 years ago

HI @wadouk , @rchatley asked me to look into this patch. I was able to get a running extreme_startup quickly, so well done. I'd suggest a few changes:

I'd change CMD to ["ruby" "web_server.rb"] so as to not confuse people who don't use docker. (there is a fixed location for /usr/local/ruby that is not common).

I'd change the README to use docker run with -d instead of -ip, and refer to the docker documentation for how to inspect the logs, remove containers etc.

wadouk commented 9 years ago

Hi,

It would be great.

I have tried to set CMD to ["ruby web_server.rb"] but it was failling, of course. To make it working I remember to have to force to execute the permission on webserver.rb. It would be better to don't have to force permission and have a full command and revert the change with specific path. Like I was new to docker, I have preferred to recopy all the command I made because of some mismatch in [the documentation](https://registry.hub.docker.com//ruby/) or my misunderstanding. About the options to docker run, If ruby support don't have tty -d will be good. One of the points that was difficult to me was the difference between the image and the run container. So lots of the pointer in the readme was for docker noobs.

mostalive commented 9 years ago

Hi,

I know the feeling. Docker is easy to get started with, and then you trip over all the little details...

On 18/11/14 16:07, wadouk wrote:

Hi,

It would be great.

I have tried to set CMD to ["ruby web_server.rb"] but it was failling, of course. To make it working I remember to have to force to execute the permission on webserver.rb. It would be better to don't have to force permission and have a full command and revert the change with specific path. Like I was new to docker, I have preferred to recopy all the command I made because of some mismatch in [the documentation](https://registry.hub.docker.com//ruby/) or my misunderstanding. About the options to docker run, If ruby support don't have tty -d will be good. One of the points that was difficult to me was the difference between the image and the run container. So lots of the pointer in the readme was for docker noobs.

--- Reply to this email directly or view it on GitHub: https://github.com/rchatley/extreme_startup/pull/36#issuecomment-63494860

www.qwan.eu - @mostalive uk mobile: +447438651672 dutch mobile: +31684255792 skype: willemvandenende

wadouk commented 9 years ago

If you want i could make the changes on friday if you don't make it before

rchatley commented 9 years ago

Hi @wadouk, if you could make the changes that would be great and then we can have another look at the PR.

On Wed, Nov 19, 2014 at 9:42 AM, wadouk notifications@github.com wrote:

If you want i could make the changes on friday if you don't make it before

— Reply to this email directly or view it on GitHub https://github.com/rchatley/extreme_startup/pull/36#issuecomment-63614204 .

wadouk commented 9 years ago

is it better like that ?

mostalive commented 9 years ago

That looks fine to me. Robert, can you merge it? Thanks @wadouk , this is very useful.

rchatley commented 9 years ago

Merged.

Thanks very much for your contribution @wadouk, and Willem for the review.

--Robert

On Tue, Nov 25, 2014 at 3:45 PM, Willem van den Ende < notifications@github.com> wrote:

That looks fine to me. Robert, can you merge it?

— Reply to this email directly or view it on GitHub https://github.com/rchatley/extreme_startup/pull/36#issuecomment-64419617 .