search

rchillyard / The-repository-formerly-known-as

2 stars 12 forks source link

Implemented functionality to determine whether string are properly en… #35

Closed rchillyard closed 4 years ago

rchillyard commented 4 years ago

…coded or not

rchillyard commented 4 years ago

I'd like to see data showing the effect of this functionality on performance. Need to see both favorable and unfavorable cases. Also, I need to see the failed checks corrected.

rchillyard commented 4 years ago

Can you explain why the implementation of perfect() in HuskySequenceCoder was changed? I don't understand that. It's supposed to be dependent on the class, not any particular sequence or sequences.

rchillyard commented 4 years ago

The variable perfect in asciiCoder does not seem to have any transactional semantics. It's initialized as true but never reinitialized. That suggests that one HuskyCoder can be used only for one sort. Perhaps that's OK but we need to make that clear if that's the case.

darshan-dedhia commented 4 years ago

Can you explain why the implementation of perfect() in HuskySequenceCoder was changed? I don't understand that. It's supposed to be dependent on the class, not any particular sequence or sequences.

I made a mistake there. I will be fixing that up. Will rollback HuskySequenceCoder.perfect() to previous one. Also, the Perfect() method is individually implemented in all the dependent classes.