search

rchillyard / The-repository-formerly-known-as

2 stars 12 forks source link

Radix sort #52

Open rchillyard opened 2 years ago

rchillyard commented 2 years ago

This PR is to enable radix sort in Husky sort.

NiftyMule commented 2 years ago

Hi professor, found a small bug for huskySort sorting Chinese in pinyin order:

PureHuskySort.java#L52, here the second pass to fix remaining inversions will need to use collactor.compare() if not sorting in unicode default order :octocat:

rchillyard commented 2 years ago

Hi professor, found a small bug for huskySort sorting Chinese in pinyin order:

PureHuskySort.java#L52, here the second pass to fix remaining inversions will need to use collactor.compare() if not sorting in unicode default order :octocat:

This has now been fixed. Maybe you'd like to create an issue(s) which covers this aspect and also the problem of the negative long numbers. I can then show this PR as fixing them.

NiftyMule commented 2 years ago

Issues created! [#53] and [#54]