search

rchlumsk / RavenR

R package for handling Raven hydrologic modelling framework inputs, outputs, and diagnostics
36 stars 16 forks source link

rvn_rvt_ECmet #45

Closed rchlumsk closed 3 years ago

rchlumsk commented 3 years ago

Change default filename writing to have rvt extension but not in file name

Currently writes out: "station_name.rvt.rvt"

scantle commented 3 years ago

@rchlumsk another issue with this function, while we're at it - the snowfall data is in solid cm, which needs to be converted to mm, but also needs a density correction to SWE mm. If you look at an ECmet data total precip column you'll see they assume 1 cm snow = 1 mm SWE (10% density). Either we should assume the same or have an argument for it. In other words, right now we're adding in ~10x the correct amount of water through the snowfall data!

scantle commented 3 years ago

In my fork, I opted for having rvn_rvt_write() check if the extension is already present before adding it:

  #-- Correct file extension if not included
  if (rvn_substrRight(ff,4) != ".rvt") {
    ff <- paste0(ff,".rvt")
  }
rchlumsk commented 3 years ago

One more item here, having forcing_set be defined as either a pre-determined number (easy sets to use) or specified columns from the forcing sets (i.e. c("temp_max","temp_min") ) would be great.