rvn_hyd_read uses system timezone by default; problems with daylight savings time

rchlumsk / RavenR

R package for handling Raven hydrologic modelling framework inputs, outputs, and diagnostics

36 stars 16 forks source link

rvn_hyd_read uses system timezone by default; problems with daylight savings time #69

Closed analytophile closed 3 years ago

analytophile commented 3 years ago

rvn_hyd_read broke for me when timezone shifted to EDT from EST. Raven outputs never have explicit timezone or daylight savings, so we could (1) assume everything was in UTC, or (2) auto shift to timezone without daylight savings. I suspect this issue is in a number of routines reading model output using as.POSIXct()

rchlumsk commented 3 years ago

Updated all read functions to explicitly set default to UTC as the simplest solution