search

rcjsuen / dockerfile-language-service

Dockerfile language service for providing an API to create feature-rich Dockerfile editors in JavaScript.
MIT License
16 stars 2 forks source link

Investigate failing test related to Docker Store #111

Open rcjsuen opened 1 year ago

rcjsuen commented 1 year ago

https://github.com/rcjsuen/dockerfile-language-service/blob/650cdff4925ba3d1ac788457a2f5c1f0df1e2c85/test/dockerAssist.registry.test.ts#L108-L115

  1) Docker Content Assist Registry Tests
       FROM
         Docker Store published images
           issue #50:

      AssertionError [ERR_ASSERTION]: Expected "actual" to be strictly unequal to: 0
      + expected - actual

      at assertImageTags (out/test/dockerAssist.registry.test.js:37:12)
      at Context.<anonymous> (out/test/dockerAssist.registry.test.js:126:21)
      at Generator.next (<anonymous>)
      at fulfilled (out/test/dockerAssist.registry.test.js:5:58)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

This test was introduced to fix #50. Given this announcement it's likely that "Docker Store" itself no longer exists as a separate entity. We will remove the test for now (to prevent releases from going out) and continue an evaluation of what our next steps should be in parallel.