rcjsuen / dockerfile-language-service

Dockerfile language service for providing an API to create feature-rich Dockerfile editors in JavaScript.
MIT License
16 stars 2 forks source link

Add code completion support for the `--start-interval` HEALTHCHECK flag #117

Closed prikhi closed 9 months ago

prikhi commented 11 months ago

The HEALTHCHECK command supports a --start-interval=<duration> flag that controls the check's interval during the specified --start-period:

https://docs.docker.com/engine/reference/builder/#healthcheck

rcjsuen commented 9 months ago

Hello, @prikhi. What feature or features are you looking for with regards to this new flag?

prikhi commented 9 months ago

The autocompletion doesn't include it & if I put it in manually I get an Unknown flag: start-interval error

rcjsuen commented 9 months ago

The autocompletion doesn't include it & if I put it in manually I get an Unknown flag: start-interval error

Thank you for clarifying what features you are interested in.

The false positive in the linter is tracked by https://github.com/rcjsuen/dockerfile-utils/issues/115. I will make sure support for code completion is implemented as well.

rcjsuen commented 9 months ago

@prikhi This is now included in 0.11.0 of the language service and 0.11.0 of the language server. Thank you for bringing this to our attention!