search

rclex / arm32v7_ros_docker

Dockerfile for ROS 2 on arm32v7 arch by building from source
Apache License 2.0
0 stars 1 forks source link

add `--platform linux/arm/v7` option on the instruction #8

Closed takasehideki closed 5 months ago

takasehideki commented 5 months ago

Related to https://github.com/rclex/arm32v7_ros_docker/issues/6#issuecomment-2008969639, the option is needed to specify the platform architecture. This is a minor correction, but I want to make it clear on the instructions for our future.

@pojiro Is my understanding correct?

pojiro commented 5 months ago

@takasehideki

I'm not sure. Because our Dockerfile.humble is based arm32v7/ubuntu. I think the image itself has the arm32v7 arch binaries. So we could build the ROS 2 binaries for arm32v7 targets and at that time I didn't add the --platform option.

I read the https://docs.docker.com/build/guide/multi-platform/, especially Update the Dockerfile section. I think this platform option doesn't fit our case. WDYT?

takasehideki commented 5 months ago

@pojiro Oh! You are right!! and my understanding was wrong;;( I actually checked this option was not necessary. so I will withdraw this PR.