search

rclone / rclone

"rsync for cloud storage" - Google Drive, S3, Dropbox, Backblaze B2, One Drive, Swift, Hubic, Wasabi, Google Cloud Storage, Azure Blob, Azure Files, Yandex Files
https://rclone.org
MIT License
47.17k stars 4.22k forks source link

Add a "don't ask again" for rclone ncdu file deletion #3402

Open YenForYang opened 5 years ago

YenForYang commented 5 years ago

What is your current rclone version (output from rclone version)?

Latest beta and/or 1.48.0

What problem are you are trying to solve?

Get that last piece of functionality to match Yorhel's ncdu -- the don't ask again when deleting a file or folder.

How do you think rclone should be changed to solve that?

Simply by adding the option to the rclone ncdu GUI.

I've found rclone ncdu to be an excellent portable replacement for Yorhel's ncdu on windows. The problem is that it's a pain to delete multiple files with the confirmation popping up every time. Perhaps the --auto-confirm flag could be used to disable the prompt; or maybe just add a the option to the dialog box to not ask again.

ncw commented 5 years ago

Great idea!

I like the idea of the dialog box - "Delete? Yes, Yes and Don't Ask Again, No"

Would you like to work on this?

YenForYang commented 5 years ago

About 2-3 weeks from now I might have chance to work on this (currently working on a couple projects in C++ -- if I knew Go as well as I know C++, I'd probably be able squeeze it in sooner).

I'm very much hoping someone else more familiar with Go can pick it up before then, as I'm not exactly sure how the rclone ncdu command works (i.e. not sure how to add this functionality).

archon810 commented 5 years ago

I, on the other hand, would like to request a --readonly flag so that I can't accidentally delete and only use ncdu for figuring out remote data usage for services like Drive that don't show folder sizes.

I just accidentally pressed "d" on a top-level backup archive and almost had a heart attack. Thankfully, there's an "are you sure?" confirmation, but I'd rather eliminate any chance of a deletion.

Maybe we don't need 2 flags - maybe it can be a single flag with 3 values.

ncw commented 5 years ago

I, on the other hand, would like to request a --readonly flag so that I can't accidentally delete and only use ncdu for figuring out remote data usage for services like Drive that don't show folder sizes.

I just accidentally pressed "d" on a top-level backup archive and almost had a heart attack. Thankfully, there's an "are you sure?" confirmation, but I'd rather eliminate any chance of a deletion.

There is a precedence for this in ncdu

       -r  Read-only mode. This will disable the built-in file deletion
           feature. This option has no effect when "-o" is used, because there
           will not be a browser interface in that case. It has no effect when
           "-f" is used, either, because the deletion feature is disabled in
           that case anyway.

Maybe we don't need 2 flags - maybe it can be a single flag with 3 values.

I like the idea of retaining ncdu compatibility where we can.

archon810 commented 5 years ago

Oh, in that case, I welcome -r in a future release.

gary-kim commented 5 years ago

I can work on adding the read only mode.

ncw commented 5 years ago

I can work on adding the read only mode.

That would be great :-)

hex2a commented 3 years ago

I can work on adding the read only mode.

was this ever implemented? If not, should there be a separate issue for this feature request?

ncw commented 3 years ago

It isn't in the current code - I don't know whether @gary-kim has a branch for the feature?

gary-kim commented 3 years ago

I don't think I finished it