search

rcmaehl / MSEdgeRedirect

A Tool to Redirect News, Search, Widgets, Weather and More to Your Default Browser
https://MSEdgeRedirect.com
GNU Lesser General Public License v3.0
4.04k stars 93 forks source link

Won't work w/ Hurl (browser chooser) - endless loop #229

Closed lucaspestana closed 1 year ago

lucaspestana commented 1 year ago

Preflight Checklist

Install Type

New Install

Install Mode

Unsure

Steps to reproduce

I recently started using Hurl by @U-C-S, a browser choosing utility that will always pop-up a prompt, asking the user to choose which browser they want to use to open a hyperlink (usually a regular HTTPS or HTTP one).

(In case this is relevant, these are my currently installed browsers: regular Edge, Edge Dev, Vivaldi Snapshot, Firefox Developer Edition, IE11†, regular Google Chrome‡. ### † For whatever reason, IE [and IE Mode on Edges] has stopped working recently, anyway, whatever. ‡ I barely use regular Edge and Google Chrome, but I sometimes use the second one for some webapps [PWAs].)

I configured Hurl to always to prompt me choose between my three faves: Vivaldi / Edge Dev / Firefox Dev ( with a special argument for a rounded squared omnibox)

.

THE ACTUAL ISSUE:

  1. With all apps installed and configured, I try to open a news article from the News & Interests widget.
  2. MSEdgeRedirect (installed as admin) detects the microsoft-edge: hyperlink and sends it to the default "browser", which is Hurl.
  3. Hurl pops up and prompts me to choose from my three browsers. (continues…)

✔️ Expected Behavior

(…continued)

  1. What I expected to happen is that Hurl would pop up, I would choose "Edge Dev" (which's most often my preferred one of the bunch anyway), and Edge Dev would launch and load the page.
  2. NOTE: Indeed, right after installing MSEdgeRedirect (Hurl was already pre-installed), it worked fine (with that ugly fully rounded omnibox, by the way). However, from the second time around on, it didn't!… (continues again…)

❌ Actual Behavior

(…again continued)

  1. If I choose "Edge Dev" (and insist on choosing it, again and again)… an endless, l∞ping cycle ensues, where Hurl tries to pass the URL to Edge Dev (msedge.exe), but MSEdgeRedirect detects this and decides it must not be opened with disgusting Microsoft Edge, but rather with the user's default browser (which in my OS is now Hurl).
  2. I can be sure that all of the above is happening because I can see the MSEdgeRedirect.exe process loading and unloading again and again in a processes monitor app -- and msedge.exe itself never even loads.
  3. In the end, the link to the news article will never open as long as I insist on selecting "Edge Dev" and unless I choose another, non-Edge browser (Vivaldi, Firefox, etc.).
  4. I tried setting up the Active Mode(s) of MSEdgeRedirect -- but oddly, it seems the settings wouldn't stick. I dunno. I selected the checkboxes (tried: unchecking all, unchecking only Edge Dev, checking Edge Dev alone) and clicked Save; next time I opened MSEdgeRedirect Settings, the checkboxes would all be checked, regardless of my previous setup of choice.
  5. Running microsoft-edge:https://google.com and trying to choose "Edge Dev" from Hurl dead-ends in the same l∞p scenario.
  6. SOLUTION: I rarely click on Windows' own in-system links, so MSEdgeRedirect was more of a curiosity for me rather than something I actively need. (I even went as far as force-removing Internet search from Windows Search on taskbar, my Search only shows me my own apps and files and local stuff; but I digress. Besides, I actually mostly like Microsoft Edge, it's an okay everyday browser for me.) ### So, I simply uninstalled MSEdgeRedirect as normal. Everything is back to normal, Hurl works in most cases (handling regular HTTPS and HTTP links) -- and news articles from News & Interests will still open without being intercepted by Hurl.

Microsoft Windows version

Windows 10 22H2

Other Software

Microsoft Edge Dev

rcmaehl commented 1 year ago

I'll definitely look into this!

rcmaehl commented 1 year ago

Can you upload %localappdata%\MSEdgeRedirect\logs\AppGeneral.log? After some debugging, I have an idea but I need to confirm the issue.

lucaspestana commented 1 year ago

Can you upload %localappdata%\MSEdgeRedirect\logs\AppGeneral.log? After some debugging, I have an idea but I need to confirm the issue.

Here it is: https://1drv.ms/u/s!Avd_TL84UM5zqb4fgQKIO3xO0qT5Gw?e=zdM6gu (there's five .LOG files inside a single ZIP).

lucaspestana commented 1 year ago

Can you upload %localappdata%\MSEdgeRedirect\logs\AppGeneral.log? After some debugging, I have an idea but I need to confirm the issue.

I think I sent you too many files; here's only AppGeneral.log (and my apologies): https://1drv.ms/u/s!Avd_TL84UM5zqb4h7LLquClf9Cw9Iw?e=ns07G0

Let me know in case you'd like me to reinstall MSEdgeRedirect in case another further log is needed.

rcmaehl commented 1 year ago

Can you upload %localappdata%\MSEdgeRedirect\logs\AppGeneral.log? After some debugging, I have an idea but I need to confirm the issue.

I think I sent you too many files; here's only AppGeneral.log (and my apologies): https://1drv.ms/u/s!Avd_TL84UM5zqb4h7LLquClf9Cw9Iw?e=ns07G0

Let me know in case you'd like me to reinstall MSEdgeRedirect in case another further log is needed.

I'm still working on this :)

lucaspestana commented 1 year ago

Hello again. I just saw on the Winaero channel on Telegram that you updated MSEdgeRedirect. I went on to test it immediately.

I tried downloading both the latest stable version and the latest passing testing build -- both, however, indicate their version number as 0.7.3.0.

.

UNFORTUNATELY, if I install MSEdgeRedirect with Active Mode, the issue with Hurl as browser chooser persists: clicking on a news article from the News and Interests taskbar widget (in Windows 10) still opens Hurl again and again and again forever and ever as long as I keep trying to select Edge from Hurl.

HOWEVER, even though I prefer to install everything on "Program Files", not on "AppData" whenever possible, I decided to give Service Mode a try -- and to my surprise IT WORKS flawlessly. Clicking a news article opens Hurl once, I select Edge, and it opens instantly and as smoothly as a tasty sundae.

.

For now, I'll keep it installed in Service Mode (therefore in the AppData folder); but I suggest that you dig a wee bit deeper to see what could be causing issues when in Active Mode and if it's fixable at all.

Kudos and keep up the excellent work!!

rcmaehl commented 1 year ago

Let me reopen this so I don't forget again

rcmaehl commented 1 year ago

This should be fixed for active mode in the latest dev build.

U-C-S commented 1 year ago

Hey, I'm the author of Hurl, came here since I got referenced, didn't notice this one till now as the issue got closed. Is there anything I can do so You wouldn't need to hard code Hurl.exe into the code ??

rcmaehl commented 1 year ago

Hey, I'm the author of Hurl, came here since I got referenced, didn't notice this one till now as the issue got closed. Is there anything I can do so You wouldn't need to hard code Hurl.exe into the code ??

Not really. I'm breaking your functionality, not the other way around. I'll probably add more parent process aware handling soon.