rcmaehl / MSEdgeRedirect

A Tool to Redirect News, Search, Widgets, Weather and More to Your Default Browser
https://MSEdgeRedirect.com
GNU Lesser General Public License v3.0
3.96k stars 92 forks source link

Chocolatey Deploy Failing #277

Closed rcmaehl closed 1 year ago

rcmaehl commented 1 year ago

Preflight Checklist

Install Type

New Deployment (Chocolatey, Winget, Etc)

Install Mode

Unsure

Steps to reproduce

Run Chocolatey Deploy action

✔️ Expected Behavior

Chocolatey deployment successful

❌ Actual Behavior

File version is cutoff in nupkg name

image

Microsoft Windows version

Latest

Other Software

No response

rcmaehl commented 1 year ago

@gnpaone Not sure if this is a bug with set-ouput or crazy-max/ghaction-chocolatey

gnpaone commented 1 year ago

@gnpaone Not sure if this is a bug with set-ouput or crazy-max/ghaction-chocolatey

Will check this

gnpaone commented 1 year ago

This is what's happening right now: https://github.com/NuGet/Home/issues/3050#issuecomment-228857794 0.7.4.0 > 0.7.4 by nuspec and choco searches for 0.7.4.0 and the file is not found so the error occurs. This is an old issue, what changes did we do from our side for this issue to occur?

https://learn.microsoft.com/en-us/nuget/concepts/package-versioning#normalized-version-numbers

rcmaehl commented 1 year ago

This is what's happening right now: NuGet/Home#3050 (comment) 0.7.4.0 > 0.7.4 by nuspec and choco searches for 0.7.4.0 and the file is not found so the error occurs. This is an old issue, what changes did we do from our side for this issue to occur?

https://learn.microsoft.com/en-us/nuget/concepts/package-versioning#normalized-version-numbers

Went from 0.7.3.0 to 0.7.4.0?

gnpaone commented 1 year ago

Nvm, found the issue, will create a PR in around 1/2 an hr, the issue is with choco version used while creating package, the new 2.0.0 version does allow non semver versions but the catch/bug is pack command stricts the semver rule but push command allows any packed nupkg even with non semver versions (4 parts version) - it can be packed using dotnet/nuget/choco etc

rcmaehl commented 1 year ago

Nvm, found the issue, will create a PR in around 1/2 an hr, the issue is with choco version used while creating package, the new 2.0.0 version does allow non semver versions but the catch/bug is pack command stricts the semver rule but push command allows any packed nupkg even with non semver versions (4 parts version) - it can be packed using dotnet/nuget/choco etc

Sounds good

gnpaone commented 1 year ago

Done. Please try now.