Host Name is Blank - Githubissues

rcmaehl / WhyNotWin11

Detection Script to help identify why your PC is not Windows 11 Release Ready. Now Supporting Update Checks!

https://whynotwin11.org

GNU Lesser General Public License v3.0

6.13k stars 414 forks source link

Host Name is Blank #755

Closed 3gfvgFWESAs44545 closed 1 month ago

3gfvgFWESAs44545 commented 4 months ago

Describe the bug
When running silently and using the switches to produce a CSV the hostname field is blank. The other columns are filled in correctly.

To Reproduce
Run the program using the following switches /s /export CSV LOG.CSV

Expected behavior
The PC name is shown in the CSV

Screenshots

Desktop (please complete the following information):

OS: Windows 10
Version Enterprise 64bit 22H2

Additional context
I'm hoping to run this on all computers on site to produce a big CSV with the status for all computers, but obviously I will need the hostname for this to be useful. Many Thanks!

rcmaehl commented 4 months ago

Give me just a bit

rcmaehl commented 4 months ago

Screenshots

Looks like maybe the hostname ended up in the TPM field?

3gfvgFWESAs44545 commented 4 months ago

Screenshots

Looks like maybe the hostname ended up in the TPM field?

Yes you are right, so perhaps the csv creation code is slightly wrong somewhere?

rcmaehl commented 4 months ago

Should be fixed in this build:

https://github.com/rcmaehl/WhyNotWin11/actions/runs/9857483366/artifacts/1682062538

I'll have a full 2.6.1.1 version out by end of day with a couple extra changes as well.

3gfvgFWESAs44545 commented 4 months ago

Should be fixed in this build:

https://github.com/rcmaehl/WhyNotWin11/actions/runs/9857483366/artifacts/1682062538

I'll have a full 2.6.1.1 version out by end of day with a couple extra changes as well.

That version seems to be working correctly now. many thanks for the rapid fix! :)

PicoMitchell commented 1 month ago

It looks like the download for https://github.com/rcmaehl/WhyNotWin11/actions/runs/9857483366/artifacts/1682062538 has expired. Is it possible to get a new temporary build, or is there an ETA on the 2.6.1.1 final release?

micwoj92 commented 1 month ago

I've triggered new build https://github.com/rcmaehl/WhyNotWin11/actions/runs/11263682084/artifacts/2037455992

PicoMitchell commented 1 month ago

When trying to do WhyNotWin11.exe /export CSV [PATH] /silent /force with that build, I'm just getting an alert window that says only "0" and an "OK" button, and I get no exported file at the specified path.

rcmaehl commented 1 month ago

When trying to do /export CSV [PATH] /silent /force with that build, I'm just getting an alert window that says only "0" and an "OK" button, and I get no exported file at the specified path.

Gimme a sec

PicoMitchell commented 1 month ago

Correction, it IS outputting the file (I wasn't being patient enough after closing the "0" alert which the output process seems to hang on), but the alert with "0" isn't great when I need to use it silently within a script.

rcmaehl commented 1 month ago

Correction, it IS outputting the file (I wasn't being patient enough after closing the "0" alert which the output process seems to hang on), but the alert with "0" isn't great when I need to use it silently within a script.

https://github.com/rcmaehl/WhyNotWin11/actions/runs/11264180630/artifacts/2037598175

This has the dialog removed. Was fixing an edge case in which someone forgot the trailing \ in a directory

2.6.1.1 will be out tonight. I actually have most of the code for #757, I just have to finish and commit it before releasing that.

PicoMitchell commented 1 month ago

Working perfectly now. Thank you so much for the quick fix!