search

rcmaniac25 / GamePlay

Open-source, cross-platform 3D native C++ game framework making it easy to learn and write mobile and desktop games.
www.gameplay3d.org
1 stars 1 forks source link

Custom effect support in TileSheet #23

Closed marcinjakubowski closed 10 years ago

marcinjakubowski commented 10 years ago

As described in the message on gameplay3d's forums, adding support for custom effects in TileSheets. Be aware of commit fd123e9, gcc 4.7.2 complained about undefined references when linking but I'm not sure if this is compatible with MSVC or any other compiler you're using.

rcmaniac25 commented 10 years ago

It looks good. The only thing I would say is can you move the effect parameter to after initialCapacity? That way any code that already uses it won't get screwed up trying to pass, for example, 4096 as a pointer value to effect.

marcinjakubowski commented 10 years ago

Right, I didn't think of that, good point. I don't use the initialCapacity anywhere in my code but it could potentially break the existing code. Though I think the compiler would prevent you from passing an int as an Effect pointer without a cast.

I've screwed up my git repo, I'll close this one and submit another pull request shortly.