rcmcdonough / rcmcdonough.github.io

MIT License
0 stars 0 forks source link

Summary #7

Open ghost opened 6 years ago

ghost commented 6 years ago

Satisfactory 👍

You've successfully reproduced the website according to the design mock. You've demonstrated a solid understanding of using HTML to markup your page's content and structure and of using CSS to apply fundamental styles.

Try to make more strategic use of div tags, classes, and IDs to organize your HTML and CSS and make it easier to read and maintain.

ghost commented 6 years ago

@stevetoro thanks for the comments. could you be a little bit more specific. There are divs around every section, classes in every div and h2 header.

probably could have used ids in the divs instead of classes.

please also give me examples of how to make it more readable....thanks

rcmcdonough commented 6 years ago

@stevetoro i think one of your other comments covered this...maybe? so i updated the html and changed the divs to use a common id. already had classes on headers so didnt change that. let me know if you think other changes would make it more readable or would be a better 'design'