search

rcmolina / MaxDuino

Unified firmware for tzxduino and casduino
https://www.va-de-retro.com/foros/viewtopic.php?t=5541&start=9999
88 stars 21 forks source link

(Maybe a feature request) AY Files are always loaded using a fake "ZXAYFile" filename, and should ideally show the real filename from sdcard #14

Closed stripwax closed 2 years ago

stripwax commented 2 years ago

Would be quite easy to take the filename, reduce to 10 characters (pad with space if necessary, and remove characters outside of the 32-127 range), and send that as part of the writeHeader2() function

stripwax commented 2 years ago

Please consider https://github.com/stripwax/MaxDuino/commit/8c8b6893d957600300c38187ab4b439233886c2f as a solution (apologies I didn't make this a pull request, I can do that if you prefer)

rcmolina commented 2 years ago

Please consider stripwax@8c8b689 as a solution (apologies I didn't make this a pull request, I can do that if you prefer)

Yes please

stripwax commented 2 years ago

done (#18)

rcmolina commented 2 years ago

Thanks David,

Many of these error are in fact attempts to get more space, and not well tested.

No user report this, and not observed by myself.

Rafa

El mié., 8 jun. 2022 0:12, Dave Hooper @.***> escribió:

Would be quite easy to take the filename, reduce to 10 characters (pad with space if necessary, and remove characters outside of the 32-127 range), and send that as part of the writeHeader2() function

— Reply to this email directly, view it on GitHub https://github.com/rcmolina/MaxDuino_v1.76/issues/14, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKNPFGUPO3KGJTWXUOQIB3VN7CORANCNFSM5YEOUS5A . You are receiving this because you are subscribed to this thread.Message ID: @.***>