rcmolina / MaxDuino

Unified firmware for tzxduino and casduino
https://www.va-de-retro.com/foros/viewtopic.php?t=5541&start=9999
88 stars 21 forks source link

Misc fixes #35

Closed stripwax closed 1 year ago

stripwax commented 1 year ago

not thoroughly tested

rcmolina commented 1 year ago

Yes! , uploaded again. Did not see your message cause I was testing code.

Rafa

El lun., 10 abr. 2023 20:33, Dave Hooper @.***> escribió:

@.**** commented on this pull request.

In CheckForExt.ino https://github.com/rcmolina/MaxDuino/pull/35#discussion_r1161971309:

   readfile(1,bytesRead);

if (input[0] == 0x55) { out=HIGH;

  • dragonMode=1;
  • casduino == CASDUINO_FILETYPE::DRAGONMODE;

This is probably the bug. Obviously should be single = not == here!

— Reply to this email directly, view it on GitHub https://github.com/rcmolina/MaxDuino/pull/35#pullrequestreview-1377944257, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKNPFFLNNDXRPORF2ES4WDXARG7DANCNFSM6AAAAAAWWBHNVU . You are receiving this because you modified the open/close state.Message ID: @.***>