search

rconroy293 / mtga-log-client

GNU General Public License v3.0
61 stars 26 forks source link

Add type hints to mtga_follower #123

Closed mverderese closed 1 year ago

mverderese commented 1 year ago

Python Type Hints add clarity to the ambiguity of variable, argument, and function return types in python. They can be added without having any effect on the code runing at all.

Some of the types added are still relatively generic, but can be made more specific over time.

There are tools, such as mypy that can be added to the linting and CI process to validate that the code is utilizing types correct and helps prevent subtle bugs. This may be added in a subsequent change-set.

rconroy293 commented 1 year ago

I'll decline this for now given all of the changes, but please feel free to reopen once conflicts are resolved!