rcore-os / rCore-Tutorial-v3

Let's write an OS which can run on RISC-V in Rust from scratch!
https://rcore-os.github.io/rCore-Tutorial-Book-v3/index.html
GNU General Public License v3.0
1.58k stars 452 forks source link

Some flaws in rust-toolchain.toml and Dockerfile #138

Closed jklincn closed 7 months ago

jklincn commented 7 months ago
  1. rust-toolchain.toml

  2. Dockerfile

    • There is a flaw of a duplicate software package installation, such as git and curl.
    • It can use multi-stage building to reduce image size. For example, move the compilation of QEMU to another build stage.
    • Since the docker image is built up from a series of layers, RUN rm foo after RUN wget foo could not reduce image size.
    • Due to the special network environment, should a mirror or accelerated source be configured?